Parse output labels automatically #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use his examples as tests
|
|
Pull Request Test Coverage Report for Build 5578967633
💛 - Coveralls |
Breaks other tests, demos, and docs still
No docs or demo yet
This way we have a route for handling cases scraping can't (like multiple return branches), but it comes at the user/node designer assuming that risk themself.
liamhuber
changed the title
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This was referenced Jul 17, 2023
Merged
Namely, on_run should be a property returning a callable
They are not implemented and working yet, so at least fail cleanly!
And downstream stuff like `update` and thus `__call__`. This was requested by Joerg and now makes things really start to feel like regular python
We may wish to later make Macro's slow, but for Workflows, since the IO is just routing through to the owned nodes, input updates are _anyhow_ most of the time re-running things, so it's a sensible default IMO
Return output when calling `run`
Clean executor fails
Node input as args
liamhuber
added
format_black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717
First, this makes it easier to define new nodes, since there will just be less to write. Second, this will let us free up
*argsinFunction(Node)to be used for providing input data (as discussed in #769). We'll still allow explicitly providing different output labels, but this becomes an optional kwarg instead of mandatory args.Best-practice becomes to give good variable names to all the return values in your wrapped function, but Sam's parser is super generic and you'll still be able to access weirdly-named nodes with
["node name"]even if they're not dot-accessible. (At least that's the plan!)Function(Node)and its children